fix: leave space for autohide taskbar for frameless maximized window #18321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #18310.
When autohide taskbar is enabled, the window needs to leave some space for it when maximized. Chromium already does the trick for normal window, however it is not doing the trick for frameless window.
Since Chromium is deprecating Chrome Apps and it does not use frameless windows in other parts of code, I don't think Chromium will fix it for us, and patching Chromium may not be a good idea since all frameless window code may gradually stop working.
So in this PR I followed Chromium's trick on resizing the maximized window to leave space for autohide taskbar when using frameless window. It should be able to work through time no matter what Chromium does with its frameless window code.
Checklist
npm test
passesRelease Notes
Notes: Fix autohide taskbar not showing when frameless window is maximized.