Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leave space for autohide taskbar for frameless maximized window #18321

Merged
merged 1 commit into from
May 21, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented May 16, 2019

Description of Change

Close #18310.

When autohide taskbar is enabled, the window needs to leave some space for it when maximized. Chromium already does the trick for normal window, however it is not doing the trick for frameless window.

Since Chromium is deprecating Chrome Apps and it does not use frameless windows in other parts of code, I don't think Chromium will fix it for us, and patching Chromium may not be a good idea since all frameless window code may gradually stop working.

So in this PR I followed Chromium's trick on resizing the maximized window to leave space for autohide taskbar when using frameless window. It should be able to work through time no matter what Chromium does with its frameless window code.

Checklist

Release Notes

Notes: Fix autohide taskbar not showing when frameless window is maximized.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 16, 2019
@zcbenz zcbenz force-pushed the frameless-maximized-autohide-taskbar branch from 3dd2596 to 6c405b7 Compare May 16, 2019 10:06
@zcbenz zcbenz force-pushed the frameless-maximized-autohide-taskbar branch from 6c405b7 to d4cb6b4 Compare May 16, 2019 11:24
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 17, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch seems large at first but most of the lines are just mechanical -- either adding in the Chromium code, or adding the shims to ensure it gets code, e.g. separating the X and Win implementations of Maximize.

Overall LGTM. I agree with the rationale in the description for copying in what we need.

atom/browser/native_window_views_win.cc Show resolved Hide resolved
@ckerr ckerr merged commit 340014a into master May 21, 2019
@release-clerk
Copy link

release-clerk bot commented May 21, 2019

Release Notes Persisted

Fix autohide taskbar not showing when frameless window is maximized.

@ckerr ckerr deleted the frameless-maximized-autohide-taskbar branch May 21, 2019 00:50
@trop
Copy link
Contributor

trop bot commented May 21, 2019

I have automatically backported this PR to "6-0-x", please check out #18373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frameless window prevents taskbar unhide
2 participants