ci: add check for dist zip file changes #18446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
force-pushed
the
dist-zip-manifest
branch
from
d7256c7
to
c1bfbc7
Compare
nornagon
force-pushed
the
dist-zip-manifest
branch
from
e83889e
to
59a51ea
Compare
|
No Release Notes |
6 tasks
3 tasks
|
A maintainer has manually backported this PR to "6-0-x", please check out #19172 |
3 tasks
|
A maintainer has manually backported this PR to "5-0-x", please check out #19173 |
3 tasks
|
A maintainer has manually backported this PR to "4-2-x", please check out #19175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This will cause CI to fail if files are added or removed to the dist.zip bundle without associated changes to the manifest files. This should prevent files from being inadvertently added or removed from the bundle we ship to users.
Checklist
npm testpassesRelease Notes
Notes: no-notes