Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add check for dist zip file changes #19173

Merged
merged 1 commit into from Jul 11, 2019
Merged

ci: add check for dist zip file changes #19173

merged 1 commit into from Jul 11, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 9, 2019 •
edited

Description of Change

Backport of #18446

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@trop trop bot mentioned this pull request Jul 9, 2019
Merged
6 tasks
@miniak miniak self-assigned this Jul 9, 2019
@miniak miniak added 5-0-x backport This is a backport PR labels Jul 9, 2019
@miniak miniak requested a review from jkleinsc July 9, 2019 16:54
@miniak miniak force-pushed the miniak/dist-zip-manifest-5-0-x branch from ab6c59c to f811700 Compare July 9, 2019 17:39
@miniak miniak added the wip ⚒ label Jul 9, 2019
@miniak miniak force-pushed the miniak/dist-zip-manifest-5-0-x branch from f811700 to 50a8e19 Compare July 9, 2019 20:30
@miniak miniak added wip ⚒ and removed wip ⚒ labels Jul 9, 2019
@miniak miniak mentioned this pull request Jul 11, 2019
Merged
4 tasks
@zcbenz
Copy link
Member

zcbenz commented Jul 11, 2019

There is a wip tag on this PR, @miniak I think it is ready for merge as #19192 and #19193 are already merged?

@miniak miniak force-pushed the miniak/dist-zip-manifest-5-0-x branch from 50a8e19 to 60e141d Compare July 11, 2019 15:09
@miniak miniak removed the wip ⚒ label Jul 11, 2019
@miniak
Copy link
Contributor Author

miniak commented Jul 11, 2019

@zcbenz rebased and ready to be merged as soon as the CI passes

@codebytere codebytere merged commit dd58f2a into 5-0-x Jul 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2019

No Release Notes

@codebytere codebytere deleted the miniak/dist-zip-manifest-5-0-x branch July 11, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @zcbenz @nornagon @alexeykuzmin @jkleinsc @codebytere