Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly pass openExternal activate option #18657

Merged
merged 4 commits into from Jun 10, 2019
Merged

fix: properly pass openExternal activate option #18657

merged 4 commits into from Jun 10, 2019

Commits on Jun 5, 2019

  1. fix: properly pass openExternal activate option 

    A reference to an OpenExternalOptions structure was being captured by an Objective-C block that
outlived the object that was being referenced.
    @jeremyspiegel
    jeremyspiegel committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    41fc738 View commit details
    Browse the repository at this point in the history

  2. Fix test in CI

    @jeremyspiegel
    jeremyspiegel committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    449ce24 View commit details
    Browse the repository at this point in the history

  3. Don't check for activate on linux

    @jeremyspiegel
    jeremyspiegel committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    bf31cd2 View commit details
    Browse the repository at this point in the history

  4. Close BrowserWindow

    @jeremyspiegel
    jeremyspiegel committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    da6be32 View commit details
    Browse the repository at this point in the history