fix: properly pass openExternal activate option

[jeremyspiegel]

Description of Change

A reference to an OpenExternalOptions structure was being captured by an Objective-C block that outlived the object that was being referenced (added in #15065). This caused the default browser window to not be activated when passing a URL on macOS when the default browser is Safari or Firefox. Fixes #18293.

cc @miniak @nornagon @alexeykuzmin @codebytere

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed issue where shell.openExternal would not activate opened window on macOS

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[jeremyspiegel]

Looks like I can't rely on a window onblur event in a test on CI (it worked when I ran it via npm run test). Not sure how else to test this, so maybe it'd be best to just revert the test change I made.

[jeremyspiegel]

Hmm, I see now that with #17649, osx-testing-test doesn't pass on PRs from forks. I don't have permission to push a branch to this repo though.

[MarshallOfSound]

@jeremyspiegel That's OK, as that's the only failure this PR is effectively green. Just needs a review 👍

[codebytere]

Thanks for this!

[codebytere]

The failing macOS spec is expected for forks; merging.

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Fixed issue where shell.openExternal would not activate opened window on macOS

[trop]

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

[codebytere]

@jeremyspiegel could you please open manual backports for the targeted release lines?

[jeremyspiegel]

@codebytere sure, but the bug is not in 4.2.x, it is new in 5.0.x.

[codebytere]

@jeremyspiegel oops, corrected!

[trop]

A maintainer has manually backported this PR to "5-0-x", please check out #18721

[trop]

A maintainer has manually backported this PR to "6-0-x", please check out #18722