fix: properly pass openExternal activate option (5-0-x) #18721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #18657 to 5-0-x
Description of Change
A reference to an
OpenExternalOptions
structure was being captured by an Objective-C block that outlived the object that was being referenced (added in #15065). This caused the default browser window to not be activated when passing a URL on macOS when the default browser is Safari or Firefox. Fixes #18293.cc @codebytere
Checklist
npm test
passesRelease Notes
Notes: Fixed issue where
shell.openExternal
would not activate opened window on macOS.