feat: provide the frame URL with permission requests and checks #18757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
Jun 12, 2019
| @@ -284,15 +284,16 @@ win.webContents.session.setCertificateVerifyProc((request, callback) => { | |||
| #### `ses.setPermissionRequestHandler(handler)` | |||
|
|
|||
| * `handler` Function | null | |||
| * `webContents` [WebContents](web-contents.md) - WebContents requesting the permission. | |||
| * `webContents` [WebContents](web-contents.md) - WebContents requesting the permission. Please note that if the request comes from a subframe you should use `requestingUrl` to check the request origin. | |||
There was a problem hiding this comment.
@MarshallOfSound @felixrieseberg would it be productive to provide a snippet showing an example of this?
Also provides a handy isMainFrame property to determine if it is an iframe making the request
MarshallOfSound
force-pushed
the
feat/permission-frame-url
branch
from
8420cf8
to
5038721
Compare
deepak1556
approved these changes
Jun 13, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "4-2-x" cleanly; |
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I was unable to backport this PR to "3-1-x" cleanly; |
|
I have automatically backported this PR to "6-0-x", please check out #18772 |
MarshallOfSound
added a commit
that referenced
this pull request
Jun 13, 2019
* feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
|
A maintainer has manually backported this PR to "5-0-x", please check out #18773 |
MarshallOfSound
added a commit
that referenced
this pull request
Jun 13, 2019
* feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
|
A maintainer has manually backported this PR to "3-1-x", please check out #18774 |
MarshallOfSound
added a commit
that referenced
this pull request
Jun 24, 2019
* feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
zcbenz
pushed a commit
that referenced
this pull request
Jul 11, 2019
…) (#18773) * feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
trop bot
pushed a commit
that referenced
this pull request
Jul 11, 2019
* feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2019
…) (#19204) * feat: provide the frame URL with permission requests and checks Also provides a handy isMainFrame property to determine if it is an iframe making the request * chore: refactor to use base::Value * chore: use Set<Type>Key over SetPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18755
Users need to be able to know where the origin of the permission request is.
Notes: Added
requestingUrlandisMainFrameproperties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.