feat: provide the frame URL with permission requests and checks #18772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Also provides a handy isMainFrame property to determine if it is an iframe making the request
MarshallOfSound
force-pushed
the
trop/6-0-x-bp-feat-provide-the-frame-url-with-permission-requests-and-checks-1560449527231
branch
from
d4a6cf1
to
1bfa30c
Compare
MarshallOfSound
approved these changes
Jun 14, 2019
zcbenz
approved these changes
Jun 15, 2019
|
Release Notes Persisted
|
zcbenz
deleted the
trop/6-0-x-bp-feat-provide-the-frame-url-with-permission-requests-and-checks-1560449527231
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18757
See that PR for details.
Notes: Added
requestingUrlandisMainFrameproperties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.