fix: app.getAppPath() returning default-app path when no package.json found #18889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
…ries without package.json
5 tasks
codebytere
approved these changes
Jun 19, 2019
codebytere
requested changes
Jun 20, 2019
miniak
deleted the
trop/5-0-x-bp-fix-app-getapppath-returning-default-app-path-when-no-package-json-found-1560980081176
branch
|
@codebytere replaced by #18894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18763
See that PR for details.
Notes: Fixed
app.getAppPath()returning default-app path when runningelectron appwith no package.json orelectron app/index.js. Now the directory containing the executed file is returned.