Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: silent printing mode #18979

Merged
merged 1 commit into from Jun 27, 2019
Merged

fix: silent printing mode #18979

merged 1 commit into from Jun 27, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Fixes #18123.

Previously, printing settings weren't set if printing was silent, and so it would appear to do nothing because subsequent action relied on those being set properly.

cc @brenca

Checklist

Release Notes

Notes: Fixed silent printing across platforms.

@codebytere codebytere requested a review from a team as a code owner June 25, 2019 19:42
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2019
@codebytere codebytere requested a review from brenca June 25, 2019 19:43
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2019
@codebytere codebytere merged commit e8e360a into master Jun 27, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 27, 2019

Release Notes Persisted

Fixed silent printing across platforms.

@codebytere codebytere deleted the fix-silent-print branch June 27, 2019 03:53
@trop
Copy link
Contributor

trop bot commented Jun 27, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 27, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@codebytere codebytere mentioned this pull request Jun 28, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 28, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19037

@codebytere codebytere mentioned this pull request Jun 28, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 28, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #19038

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.12 in 6.1.x Jul 10, 2019
@SubhamBuie
Copy link

SubhamBuie commented Sep 4, 2023 •
edited

image
on windows 10 ,silent printing is not working
while "electron": "^26.1.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@brenca brenca Awaiting requested review from brenca

Assignees
No one assigned
Labels
component/printing
Projects
No open projects
6.1.x
Fixed in 6.0.0-beta.12
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'silent: true' for printing not working in version 5.
5 participants
@codebytere @SubhamBuie @jkleinsc @deepak1556 @ckerr