Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silent printing mode #19037

Merged
merged 1 commit into from Jul 2, 2019
Merged

fix: silent printing mode #19037

merged 1 commit into from Jul 2, 2019

Conversation

codebytere
Copy link
Member

Backport of #18979.

See that PR for more details.

Notes: Fixed silent printing across platforms.

@codebytere codebytere requested a review from a team as a code owner June 28, 2019 20:53
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2019
@trop trop bot mentioned this pull request Jun 28, 2019
4 tasks
@codebytere codebytere added 6-0-x backport This is a backport PR labels Jun 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkleinsc jkleinsc merged commit 48bc247 into 6-0-x Jul 2, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 2, 2019

Release Notes Persisted

Fixed silent printing across platforms.

@jkleinsc jkleinsc deleted the print-silent-6 branch July 2, 2019 17:03
@ryzokuken
Copy link

@codebytere do you think we should prefix backports with a descriptive label like Node? This was super confusing in my notifications since I had three PRs with the same title (original and two backports).

@codebytere
Copy link
Member Author

They should all be labeled, which differentiates them in the UI :)

@sarathjasrin
Copy link

This is not fixed still Version : 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants