Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move gfx::ImageSkia functions to their own util file #19460

Merged
merged 9 commits into from Jul 30, 2019

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 25, 2019

Description of Change

Inside atom_api_native_image.cc, we have a set of functions that are useful for generating gfx::ImageSkia representations.

I wanted to use those outside the context of NativeWindow in #19420, where I am reusing electron::ShowMessageBoxSync function to pop up an About dialog for Windows.

For this About Dialog, I am grabbing the message box icon from a file path, like we do in Linux.

Since gfx::ImageSkia is used outside of NativeImage, I was thinking that it'd be useful to do extract these utility functions into their own shared file instead of keeping them private within the NativeImage API file.

Would like feedback on the usefulness/viability of this!

cc @codebytere @deermichel

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2019
@erickzhao erickzhao changed the title [WIP] Refactor ImageSkia functions to their own util file Refactor ImageSkia functions to their own util file Jul 25, 2019
@erickzhao erickzhao changed the title Refactor ImageSkia functions to their own util file refactor: move ImageSkia functions to their own util file Jul 25, 2019
@erickzhao erickzhao changed the title refactor: move ImageSkia functions to their own util file refactor: move gfx::ImageSkia functions to their own util file Jul 25, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2019
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a refactor with no function change of any kind so this seems fine!

Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me.

@codebytere codebytere merged commit e74daf2 into master Jul 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2019

No Release Notes

@codebytere codebytere deleted the intern/refactor-skia-util branch July 30, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants