New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move gfx::ImageSkia
functions to their own util file
#19460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
[WIP] Refactor ImageSkia functions to their own util file
Refactor ImageSkia functions to their own util file
Jul 25, 2019
erickzhao
changed the title
Refactor ImageSkia functions to their own util file
refactor: move ImageSkia functions to their own util file
Jul 25, 2019
codebytere
reviewed
Jul 25, 2019
erickzhao
changed the title
refactor: move ImageSkia functions to their own util file
refactor: move Jul 25, 2019
gfx::ImageSkia
functions to their own util file
codebytere
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a refactor with no function change of any kind so this seems fine!
5 tasks
nornagon
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me.
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Inside
atom_api_native_image.cc
, we have a set of functions that are useful for generatinggfx::ImageSkia
representations.I wanted to use those outside the context of
NativeWindow
in #19420, where I am reusingelectron::ShowMessageBoxSync
function to pop up an About dialog for Windows.For this About Dialog, I am grabbing the message box icon from a file path, like we do in Linux.
Since
gfx::ImageSkia
is used outside ofNativeImage
, I was thinking that it'd be useful to do extract these utility functions into their own shared file instead of keeping them private within the NativeImage API file.Would like feedback on the usefulness/viability of this!
cc @codebytere @deermichel
Checklist
npm test
passesRelease Notes
Notes: no-notes