fix: normalize behavior of win.setOpacity() for invalid number values across operating systems
#19535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
win.setOpacity() for invalid number valueswin.setOpacity() for invalid number values across OSes
erickzhao
changed the title
win.setOpacity() for invalid number values across OSeswin.setOpacity() for invalid number values across operating systems
erickzhao
changed the title
win.setOpacity() for invalid number values across operating systemswin.setOpacity() for invalid number values across operating systems
codebytere
reviewed
Jul 30, 2019
ckerr
reviewed
Jul 31, 2019
Co-Authored-By: Charles Kerr <ckerr@github.com>
…/electron/electron into intern/set-opacity-beyond-bounds
codebytere
reviewed
Aug 1, 2019
erickzhao
force-pushed
the
intern/set-opacity-beyond-bounds
branch
from
036a33c
to
db9cefd
Compare
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
@erickzhao can you please handle these manual backports when you have a moment? |
erickzhao
added a commit
that referenced
this pull request
Aug 7, 2019
…es across operating systems (#19535) * fix: define behavior for out-of-bounds setOpacity * fix linux issue * fix getOpacity behaviour * wrong variable * normalize more stuff * docs * test: use ifdescribe helper * Update spec-main/api-browser-window-spec.ts Co-Authored-By: Charles Kerr <ckerr@github.com> * fixes * more tests!!! * Update shell/browser/native_window_views.cc Co-Authored-By: Charles Kerr <ckerr@github.com> * Update shell/browser/native_window_mac.mm Co-Authored-By: Charles Kerr <ckerr@github.com>
|
A maintainer has manually backported this PR to "7-0-x", please check out #19673 |
|
A maintainer has manually backported this PR to "6-0-x", please check out #19723 |
|
A maintainer has manually backported this PR to "5-0-x", please check out #19724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Small fix to normalize behavior for invalid values for the
win.setOpacity().For example:
win.setOpacity(100)orwin.setOpacity(-100).Current behavior with invalid values
Windows:
win.setOpacity(opacity): supposed to normalize the [0,1] opacity values to 255. However, for invalid values, passing inopacity * 255leads to unexpected behavior.win.getOpacity(): retrieves the invalidopacityvalue that was previously passed in.macOS:
win.setOpacity(opacity): bounds opacity value to the [0,1] range (i.e.(opacity < 0) -> (opacity = 0)and(opacity > 1) -> (opacity = 1))win.getOpacity(): retrieves the invalidopacityvalue that was previously passed in.Linux (unsupported):
win.setOpacity(opacity): takes no action on the actual window opacity, but stores theopacityvalue.win.getOpacity(): retrieves the previously storedopacityvalue.Proposed behavior
win.setOpacity(opacity): bounds opacity value to the [0,1] rangewin.getOpacity(): retrieves the bounded opacity value.win.setOpacity(opacity): takes no action.win.getOpacity(): always returns 1.Checklist
npm testpassesRelease Notes
Notes: Normalized out-of-bound value behavior for the
setOpacity()API inBrowserWindow.