Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize behavior of win.setOpacity() for invalid number values across operating systems #19535

Merged
merged 14 commits into from Aug 7, 2019
Merged

fix: normalize behavior of win.setOpacity() for invalid number values across operating systems #19535

merged 14 commits into from Aug 7, 2019

Commits on Jul 30, 2019

  1. fix: define behavior for out-of-bounds setOpacity

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    859421e View commit details
    Browse the repository at this point in the history

  2. fix linux issue

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    68bdd16 View commit details
    Browse the repository at this point in the history

  3. fix getOpacity behaviour

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    e2a597b View commit details
    Browse the repository at this point in the history

  4. wrong variable

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    48984cf View commit details
    Browse the repository at this point in the history

  5. normalize more stuff

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    bfb49ce View commit details
    Browse the repository at this point in the history

  6. docs

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    7d34c20 View commit details
    Browse the repository at this point in the history

  7. test: use ifdescribe helper

    @erickzhao
    erickzhao committed Jul 30, 2019
    Copy the full SHA
    83fc694 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Update spec-main/api-browser-window-spec.ts 

    Co-Authored-By: Charles Kerr <ckerr@github.com>
    @erickzhao @ckerr
    erickzhao and ckerr committed Jul 31, 2019
    Copy the full SHA
    a970160 View commit details
    Browse the repository at this point in the history

  2. fixes

    @erickzhao
    erickzhao committed Jul 31, 2019
    Copy the full SHA
    b993a5e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'intern/set-opacity-beyond-bounds' of https://github.com… 

    …/electron/electron into intern/set-opacity-beyond-bounds
    @erickzhao
    erickzhao committed Jul 31, 2019
    Copy the full SHA
    12ae5d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. more tests!!!

    @erickzhao
    erickzhao committed Aug 2, 2019
    Copy the full SHA
    db9cefd View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2019

  1. Update shell/browser/native_window_views.cc 

    Co-Authored-By: Charles Kerr <ckerr@github.com>
    @erickzhao @ckerr
    erickzhao and ckerr committed Aug 4, 2019
    Copy the full SHA
    75b4f46 View commit details
    Browse the repository at this point in the history

  2. Update shell/browser/native_window_mac.mm 

    Co-Authored-By: Charles Kerr <ckerr@github.com>
    @erickzhao @ckerr
    erickzhao and ckerr committed Aug 4, 2019
    Copy the full SHA
    688906b View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Merge branch 'master' into intern/set-opacity-beyond-bounds

    @erickzhao
    erickzhao committed Aug 6, 2019
    Copy the full SHA
    3d6efb0 View commit details
    Browse the repository at this point in the history