Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that menu bar gets focus even when you click an item to focus it first #19710

Merged
merged 1 commit into from Aug 15, 2019

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Aug 9, 2019

Description of Change

Pretty much what the title says, right now, if you click on the menu bar and hit Esc, you can't use the arrow keys to navigate because the menu bar itself never got focus. This fixes that.

Checklist

Release Notes

Notes: Fixed a bug where you couldn't navigate the menu bar with the keyboard if you used the mouse to focus it.

@brenca brenca requested a review from erickzhao August 9, 2019 22:11
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 9, 2019
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this works for me on both Windows 10 Pro and Ubuntu 19.04! :shipit:

@ckerr ckerr merged commit 27b2747 into master Aug 15, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 15, 2019

Release Notes Persisted

Fixed a bug where you couldn't navigate the menu bar with the keyboard if you used the mouse to focus it.

@trop
Copy link
Contributor

trop bot commented Aug 15, 2019

I have automatically backported this PR to "7-0-x", please check out #19762

@trop
Copy link
Contributor

trop bot commented Aug 15, 2019

I have automatically backported this PR to "5-0-x", please check out #19763

@trop
Copy link
Contributor

trop bot commented Aug 15, 2019

I have automatically backported this PR to "6-0-x", please check out #19764

@sofianguy sofianguy added this to 6.0.3 in 6.1.x Aug 20, 2019
@sofianguy sofianguy added this to Fixed in 5.0.10 in 5.0.x Aug 20, 2019
@nornagon
Copy link
Member

This seems to have reintroduced an issue that #19708 fixed, namely that clicking the menu bar causes the main window to lose focus.

@erickzhao
Copy link
Member

Looking back, that does make sense as giving focus to the menu bar might un-focus the input fields. I wasn't careful enough to check the Fiddle example for issue #18745 w/ this PR.

I don't have access to a dev setup on Windows or Linux at the moment, but maybe @brenca would have an idea?

MarshallOfSound added a commit that referenced this pull request Aug 29, 2019
MarshallOfSound added a commit that referenced this pull request Aug 29, 2019
…ick an item to focus it first (#19710)" (#20019)

This reverts commit 27b2747.
trop bot pushed a commit that referenced this pull request Aug 29, 2019
trop bot pushed a commit that referenced this pull request Aug 29, 2019
trop bot pushed a commit that referenced this pull request Aug 29, 2019
@sofianguy sofianguy added this to Fixed in 7.0.0-beta.4 in 7.2.x Sep 3, 2019
codebytere pushed a commit that referenced this pull request Sep 4, 2019
codebytere pushed a commit that referenced this pull request Sep 4, 2019
codebytere pushed a commit that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.10
6.1.x
6.0.3
7.2.x
Fixed in 7.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

5 participants