New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure that menu bar gets focus even when you click an item to focus it first #19710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that this works for me on both Windows 10 Pro and Ubuntu 19.04!
Release Notes Persisted
|
I have automatically backported this PR to "7-0-x", please check out #19762 |
I have automatically backported this PR to "5-0-x", please check out #19763 |
I have automatically backported this PR to "6-0-x", please check out #19764 |
This seems to have reintroduced an issue that #19708 fixed, namely that clicking the menu bar causes the main window to lose focus. |
Description of Change
Pretty much what the title says, right now, if you click on the menu bar and hit
Esc
, you can't use the arrow keys to navigate because the menu bar itself never got focus. This fixes that.Checklist
npm test
passesRelease Notes
Notes: Fixed a bug where you couldn't navigate the menu bar with the keyboard if you used the mouse to focus it.