fix: don't handle browser messages before document element is created (6-0-x) #19719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidCreateDocumentElement is called before the ElectronApiServiceImpl gets bound.
6 tasks
MarshallOfSound
added
the
fast-track 🚅
MarshallOfSound
removed
the
fast-track 🚅
MarshallOfSound
added
the
fast-track 🚅
MarshallOfSound
approved these changes
Aug 12, 2019
|
Release Notes Persisted
|
6 tasks
|
Do we still need this commit c0e9761 or perhaps now we have a proper fix and it should be reverted? |
|
I think it is no longer needed, will start a PR to revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19718.
Notes: Fix async Node APIs not working after received IPC message.