feat: Allow inspection of specific shared workers #19793
Conversation
|
@JohnPop117 please add the release notes |
spec/api-web-contents-spec.js
Outdated
| contents[0].once('devtools-closed', () => { | ||
| done() | ||
| }) | ||
| contents[0].inspectSharedWorkerById(vectorOfWorkers[0].id) |
There was a problem hiding this comment.
This assumes that vectorOfWorkers has been initialized before running this test.
Please make the test self-contained.
There was a problem hiding this comment.
This test will still fail if the previous test hasn't been run. Tests should not depend on each other. Please make vectorOfWorkers a local variable of each test.
And please avoid using the word "vector", this concept doesn't exist in JavaScript. It's ok to call it simply sharedWorkers.
spec/api-web-contents-spec.js
Outdated
| }) | ||
|
|
||
| it('can inspect a specific shared worker', (done) => { | ||
| const contents = webContents.getAllWebContents() |
There was a problem hiding this comment.
Should be const contents = remote.getCurrentWebContents().
|
|
@JohnPop117 can you rebase this PR against the latest from master? |
|
This appears to have had a bad rebase |
JohnPop117
force-pushed
the
inspectWorker2
branch
from
d8e2c2c
to
279d5c9
Compare
JohnPop117
force-pushed
the
inspectWorker2
branch
from
81bfc78
to
f8fcab4
Compare
|
@JohnPop117 can you check and see if you are following your fork on CircleCI? For some reason CircleCI builds are not being triggered and according to this article if you are following the project fork on their personal account rather than the project itself on CircleCI, builds will not be triggered: |
|
Taking over due to lack of activity. This PR is not a personal contribution, but MS one. Replacement PR #20389 |
Description of Change
Added APIs to allow electron to get a list of shared web workers and then inspect
a shared worker based on its ID.
Checklist
npm testpassesRelease Notes
Notes: Added ability to inspect specific shared workers