Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation under tutorials #19804

Merged
merged 6 commits into from Aug 20, 2019
Merged

Conversation

cvaldez98
Copy link
Contributor

@cvaldez98 cvaldez98 commented Aug 16, 2019

Description of Change

Change the documentation to reflect the fact that Electron is now kept up to date with Chromium.

Checklist

  • relevant documentation is changed or added

Release Notes

notes: Update documentation to reflect that Electron is now up to date with a stable version of Chromium.

@welcome
Copy link

welcome bot commented Aug 16, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2019
@cvaldez98 cvaldez98 changed the title increase awesomeness chore: update documentation under tutorials Aug 16, 2019
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be something along the lines of "We strive to release security patches as soon as we are able to" ?

docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
@malept
Copy link
Member

malept commented Aug 16, 2019

CC: @electron/wg-docs-tools

Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
@cvaldez98 cvaldez98 changed the title chore: update documentation under tutorials docs: update documentation under tutorials Aug 16, 2019
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
cvaldez98 and others added 2 commits August 16, 2019 14:08
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2019
@codebytere codebytere merged commit fb214a5 into electron:master Aug 20, 2019
@welcome
Copy link

welcome bot commented Aug 20, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 20, 2019

Release Notes Persisted

Update documentation to reflect that Electron is now up to date with a stable version of Chromium.

@trop
Copy link
Contributor

trop bot commented Aug 20, 2019

I have automatically backported this PR to "6-0-x", please check out #19843

@trop
Copy link
Contributor

trop bot commented Aug 20, 2019

I have automatically backported this PR to "7-0-x", please check out #19844

@sofianguy sofianguy added this to Fixed in 6.0.4 in 6.1.x Aug 26, 2019
@sofianguy sofianguy added this to Fixed in 7.0.0-beta.4 in 7.2.x Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
6.1.x
Fixed in 6.0.4
7.2.x
Fixed in 7.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

4 participants