Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate breakpad symbols before stripping #20530

Merged
merged 2 commits into from Oct 14, 2019
Merged

fix: generate breakpad symbols before stripping #20530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7dff44
fix: generate breakpad symbols before stripping
nornagon Oct 10, 2019
50b01a6
store symbols as circleci artifacts
nornagon Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -553,6 +553,11 @@ step-maybe-zip-symbols: &step-maybe-zip-symbols
ninja -C out/Default electron:electron_version
electron/script/zip-symbols.py -b $BUILD_PATH

step-symbols-store: &step-symbols-store
store_artifacts:
path: src/out/Default/symbols.zip
destination: symbols.zip

step-maybe-cross-arch-snapshot: &step-maybe-cross-arch-snapshot
run:
name: Generate cross arch snapshot (arm/arm64)
Expand Down Expand Up @@ -859,6 +864,7 @@ steps-electron-build: &steps-electron-build

- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test
Expand Down Expand Up @@ -933,6 +939,7 @@ steps-electron-build-with-inline-checkout-for-tests: &steps-electron-build-with-

- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test
Expand All @@ -953,11 +960,12 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish

# Electron app
- *step-electron-build
- *step-maybe-generate-breakpad-symbols
- *step-maybe-electron-dist-strip
- *step-electron-dist-build
- *step-electron-dist-store
- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# mksnapshot
- *step-mksnapshot-build
Expand Down