chore: remove deprecated <webview>.getWebContents() #20986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
miniak
force-pushed
the
miniak/webview-webcontents-cleanup
branch
from
ace23a9
to
37bc992
Compare
miniak
force-pushed
the
miniak/webview-webcontents-cleanup
branch
from
37bc992
to
fd2a1ac
Compare
jkleinsc
approved these changes
Nov 8, 2019
|
Release Notes Persisted
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove
<webview>.getWebContents()deprecated in #20726.The issue described in #18462 can no longer happen.
Checklist
npm testpassesRelease Notes
Notes: Removed deprecated
<webview>.getWebContents().