fix: refactor printing for mojo #21026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
commented
Nov 7, 2019
codebytere
commented
Nov 7, 2019
codebytere
force-pushed
the
printing-fixes-for-mojo
branch
from
122f363
to
0aff4be
Compare
codebytere
changed the title
codebytere
force-pushed
the
printing-fixes-for-mojo
branch
2 times, most recently
from
0188b4f
to
f58453d
Compare
codebytere
changed the title
nornagon
requested changes
Nov 7, 2019
codebytere
force-pushed
the
printing-fixes-for-mojo
branch
2 times, most recently
from
59e15e7
to
d67879b
Compare
codebytere
force-pushed
the
printing-fixes-for-mojo
branch
from
d67879b
to
f5d4f3e
Compare
3 tasks
nornagon
approved these changes
Nov 8, 2019
jkleinsc
approved these changes
Nov 8, 2019
|
Release Notes Persisted
|
|
note: this can't be backported to 8 until #20839 lands |
codebytere
added a commit
that referenced
this pull request
Nov 9, 2019
4 tasks
|
@codebytere has manually backported this PR to "8-x-y", please check out #21059 |
|
Can this be backported to v6? |
|
@codebytere sorry for bothering, but can this be backported to Electron v5 or 6? |
|
@gordonel it cant; this relies on changes which didn't exist in those versions of Chromium sadly. |
|
Thanks.
-------- Original Message --------
…On 5 Jan 2020, 15:40, Shelley Vohr wrote:
***@***.***(https://github.com/gordonel) it cant; this relies on changes which didn't exist in those versions of Chromium sadly.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#21026?email_source=notifications&email_token=AKYUTQTNGFRKIZJVLR75ZMDQ4HPOVA5CNFSM4JKCCJ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIDXGDA#issuecomment-570913548), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AKYUTQWY2O4M7G32LVD4X3DQ4HPOVANCNFSM4JKCCJ3Q).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #19008.
Fixes printing in the aftermath of its mojoification.
Checklist
npm testpassesRelease Notes
Notes: Fixed printing.