Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add app.getApplicationNameForProtocol API (8-x-y) #21117

Merged
merged 1 commit into from Nov 14, 2019

Commits on Nov 13, 2019

  1. feat: add app.getApplicationNameForProtocol API (electron#20399)

    * Add GetApplicationNameForProtocol.
    
    * Fix Windows implementation.
    
    * Fix up test.
    
    * Add documentation.
    
    * Implement for real on Linux using xdg-mime.
    
    Also ensure we allow blocking calls here to avoid errant DCHECKing.
    
    * Improve docs for Linux.
    
    * Clean up tests.
    
    * Add a note about not relying on the precise format.
    
    * Update docs/api/app.md
    
    Co-Authored-By: Shelley Vohr <codebytere@github.com>
    
    * Remove needless `done()`s from tests.
    
    * Use vector list initialization.
    
    * Add a simple test for isDefaultProtocolClient.
    
    * Remove unneeded include and skip a test on Linux CI.
    
    * We no longer differentiate between CI and non-CI test runs.
    ajmacd committed Nov 13, 2019
    Copy the full SHA
    6656683 View commit details
    Browse the repository at this point in the history