fix: avoid Electron.dsym files in the main app bundle

[deepak1556]

Description of Change

This regressed since v7

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: remove Electron.dsym from macOS application zip

[deepak1556]

Only enabled the dist checks, haven't fixed the issue yet.

[deepak1556]

The regression came from https://chromium-review.googlesource.com/c/chromium/src/+/1671667, the following would do the trick

diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 3c816242375c..9b8bee7b4855 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -351,7 +351,7 @@ template("mac_framework_bundle") {
       ":$_shared_library_bundle_data",
     ]
 
-    if (enable_dsyms) {
+    if (enable_dsyms && !is_electron_build) {
       data = [
         "$root_out_dir/$_output_name.dSYM/Contents/Info.plist",
         "$root_out_dir/$_output_name.dSYM/Contents/Resources/DWARF/$_output_name",
@@ -559,7 +559,7 @@ template("mac_app_bundle") {
       deps += [ ":$_pkg_info_bundle_data" ]
     }
 
-    if (enable_dsyms) {
+    if (enable_dsyms && !is_electron_build) {
       data = [
         "$root_out_dir/$_output_name.dSYM/Contents/Info.plist",
         "$root_out_dir/$_output_name.dSYM/Contents/Resources/DWARF/$_output_name",
@@ -632,7 +632,7 @@ template("mac_plugin_bundle") {
     }
     deps += [ ":$_loadable_module_bundle_data" ]
 
-    if (enable_dsyms) {
+    if (enable_dsyms && !is_electron_build) {
       data = [
         "$root_out_dir/$_output_name.so.dSYM/Contents/Info.plist",
         "$root_out_dir/$_output_name.so.dSYM/Contents/Resources/DWARF/$_output_name.so",

since I don't want to mess the runtime_deps by manipulating data, data_deps without patch. But open to other solutions.

[nornagon]

Probably better to just exclude them in our zip code: https://github.com/electron/electron/blob/master/build/zip.py#L14-L23

[deepak1556]

@nornagon updated, can we trigger release builds for this PR before merging ?

[nornagon]

i can't trigger release builds but @jkleinsc can! i've pinged him.

[jkleinsc]

Mac release builds have been triggered.

[deepak1556]

Build artifacts looks good, ready for review.

[jkleinsc]

LGTM

[jkleinsc]

Merging as CI failures are unrelated to PR change.

[release-clerk]

Release Notes Persisted

remove Electron.dsym from macOS application zip

[trop]

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "8-x-y", please check out #21484

[trop]

@deepak1556 has manually backported this PR to "7-1-x", please check out #21487