fix: crash when doing redirect navigation with webRequest listener #21838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Jan 20, 2020
| @@ -538,8 +541,7 @@ void ProxyingURLLoaderFactory::InProgressRequest::ContinueToBeforeRedirect( | |||
|
|
|||
| factory_->web_request_api()->OnBeforeRedirect(&info_.value(), request_, | |||
| redirect_info.new_url); | |||
| target_client_->OnReceiveRedirect(redirect_info, | |||
| std::move(current_response_)); | |||
| target_client_->OnReceiveRedirect(redirect_info, current_response_.Clone()); | |||
There was a problem hiding this comment.
Should we also clone the response in target_client_->OnReceiveResponse ?
There was a problem hiding this comment.
Yeah it should also be changed, thanks for noticing this.
zcbenz
force-pushed
the
web-request-http-request-crash
branch
from
c27c086
to
2f1e71f
Compare
deepak1556
approved these changes
Jan 21, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #21597.
This PR contains 2 fixes:
navigation_ui_data.current_response_being moved instead of cloned. This is caused by Chromium changing the behavior of their API without changing the signature.Checklist
npm testpassesRelease Notes
Notes: Fix crash when doing redirect navigation with
webRequestlistener.