Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some websites using WebComponents V0 not loading #21858

Merged
merged 1 commit into from Jan 22, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 22, 2020

Description of Change

Closes #21596.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1869562

Fixes an issue where any website using Polymer 2.x would not load, as Polymer 2.x still uses HTML Imports as a loading mechanism. This adds the flag to enable them back for the time being, since Electron does not support origin trials and so wouldn't respect individual sites enabling them.

Another potential approach to this would be to add HTMLImports to the enableBlinkFeatures defaults, since that's more granular. Finally, we may choose to simply force consumers to work around the issue themselves, but I would say that for now I personally am in favor of leaving this enabled while it affects a nontrivial number of sites.

cc @nornagon @deepak1556 @zcbenz

Checklist

Release Notes

Notes: Fixed an issue where sites using ShadowDOMV0, CustomElementsV0, or HTMLImports would not load properly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 22, 2020
@deepak1556
Copy link
Member

I think build flag is overkill for this one, apps that don't want the feature can just pass it through --disable-features to disable it.

LGTM otherwise, nice find. I am surprised youtube is an affected site based on the description from the CL.

@zcbenz
Copy link
Member

zcbenz commented Jan 22, 2020

I'm good with this, but all Windows PRs are failing. They seem all flaky, we should have a retry of the tests before merging.

@zcbenz zcbenz merged commit a5d5e76 into master Jan 22, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2020

Release Notes Persisted

Fixed an issue where sites using ShadowDOMV0, CustomElementsV0, or HTMLImports would not load properly.

@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

I have automatically backported this PR to "8-x-y", please check out #21866

@zcbenz zcbenz deleted the fix-youtube-not-loading branch January 22, 2020 13:03
@nornagon
Copy link
Member

Hm, this shouldn't have been merged as new-pr was still applied

@zcbenz
Copy link
Member

zcbenz commented Jan 23, 2020

Sorry for merging this too quickly, I didn't know the meaning of new-pr label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

youtube.com not loading on 8.0.0-beta.5
4 participants