fix: some websites using WebComponents V0 not loading #21858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #21596.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1869562
Fixes an issue where any website using Polymer 2.x would not load, as Polymer 2.x still uses HTML Imports as a loading mechanism. This adds the flag to enable them back for the time being, since Electron does not support origin trials and so wouldn't respect individual sites enabling them.
Another potential approach to this would be to add
HTMLImports
to theenableBlinkFeatures
defaults, since that's more granular. Finally, we may choose to simply force consumers to work around the issue themselves, but I would say that for now I personally am in favor of leaving this enabled while it affects a nontrivial number of sites.cc @nornagon @deepak1556 @zcbenz
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where sites using
ShadowDOMV0
,CustomElementsV0
, orHTMLImports
would not load properly.