fix: About Panel credits should be dark mode aware #21880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-dark-mode-aware-credits
branch
from
9f48176
to
55e2049
Compare
codebytere
changed the title
zcbenz
requested changes
Jan 27, 2020
codebytere
force-pushed
the
fix-dark-mode-aware-credits
branch
from
f635fd7
to
afa728f
Compare
zcbenz
reviewed
Jan 27, 2020
codebytere
force-pushed
the
fix-dark-mode-aware-credits
branch
from
afa728f
to
d55cf84
Compare
zcbenz
approved these changes
Jan 28, 2020
|
Release Notes Persisted
|
This was referenced Jan 28, 2020
|
I have automatically backported this PR to "7-1-x", please check out #21924 |
|
I have automatically backported this PR to "6-1-x", please check out #21925 |
|
I have automatically backported this PR to "8-x-y", please check out #21926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an issue surfaced by @bnb where by the Credits option in
app.showAboutPanel()did not appropriately adapt to dark mode.Before:
After:
cc @MarshallOfSound @zcbenz @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS.