fix: compilation of native modules on windows with older msvc versions

[deepak1556]

Description of Change

https://chromium-review.googlesource.com/c/v8/v8/+/1847361 started using C++ [[deprecated]] attribute which has issues when building with msvc from VS2015. Native modules compiling with this version will have error of the format error C2416: attribute 'deprecated("..")' cannot be applied in this context from v8 headers

This can be verified with the following test case:

class A {
  public:
    [[deprecated("test")]]
    A(int a);
};

int main() {
  return 0;
}

with 2015 toolchain there will be error:

>  & 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\cl.exe' /c /I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include" test.cc

with 2017 toolchain it will compile:

> & 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x64\cl.exe' /c /I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include" test.cc

There is a msvc bug report out there which fixed this specific case, don't have the link. The PR just uses __declspec(deprecated) for those versions.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fix compilation error for native modules building with VS 2015

[deepak1556]

The version number is extracted from https://devblogs.microsoft.com/cppblog/side-by-side-minor-version-msvc-toolsets-in-visual-studio-2017/

[nornagon]

Presumably node will run into this too. should we be upstreaming this?

[deepak1556]

Yeah its better to upstream this, will do it tomorrow.

[release-clerk]

Release Notes Persisted

fix compilation error for native modules building with VS 2015

[MarshallOfSound]

@deepak1556 Can you take this back to 8?

[trop]

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

[trop]

@deepak1556 has manually backported this PR to "8-x-y", please check out #21960

[deepak1556]

Upstream CL https://chromium-review.googlesource.com/c/v8/v8/+/2032196

[deepak1556]

Please see the above CL and the v8 team has responded with their supported release lines wrt msvc, so its better we remove this patch for Electron 9 and above. Let users fix this properly on their end using VS2017 build tools.