fix: show module name in deprecation warning for context-aware modules #21952

nornagon · 2020-01-29T01:39:06Z

This adds the name of the module that's not context aware to the warning message about non-context-aware modules, for easier debugging.

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Added name of module to context-aware deprecation warning (#18397).

release-clerk · 2020-01-29T12:03:52Z

Release Notes Persisted

Added name of module to context-aware deprecation warning (#18397).

trop · 2020-01-29T12:04:26Z

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

trop · 2020-01-29T19:41:44Z

@nornagon has manually backported this PR to "8-x-y", please check out #21958

fix: show module name in deprecation warning for context-aware modules

2eff49c

nornagon added the target/8-x-y label Jan 29, 2020

nornagon requested a review from MarshallOfSound January 29, 2020 01:39

nornagon requested a review from a team as a code owner January 29, 2020 01:39

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020

deepak1556 approved these changes Jan 29, 2020

View reviewed changes

zcbenz approved these changes Jan 29, 2020

View reviewed changes

jkleinsc merged commit 0fa3c7e into master Jan 29, 2020

jkleinsc deleted the context-aware-deprecation branch January 29, 2020 12:03

trop bot added needs-manual-bp/8-x-y and removed target/8-x-y labels Jan 29, 2020

nornagon mentioned this pull request Jan 29, 2020

fix: show module name in deprecation warning for context-aware modules #21958

Merged

trop bot added in-flight/8-x-y and removed needs-manual-bp/8-x-y labels Jan 29, 2020

sofianguy added this to Fixed in 8.0.0-beta.9 in 8.2.x Jan 30, 2020

Provide feedback