fix: default printer if none is provided #21956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
default-to-default-printer
branch
from
5049e64
to
ac52be5
Compare
ckerr
reviewed
Jan 30, 2020
codebytere
force-pushed
the
default-to-default-printer
branch
from
ac52be5
to
e43d53f
Compare
ckerr
approved these changes
Jan 30, 2020
deepak1556
requested changes
Jan 30, 2020
codebytere
force-pushed
the
default-to-default-printer
branch
from
e43d53f
to
312dcbe
Compare
codebytere
force-pushed
the
default-to-default-printer
branch
from
312dcbe
to
d8c0f69
Compare
codebytere
force-pushed
the
default-to-default-printer
branch
from
d8c0f69
to
06c2968
Compare
deepak1556
approved these changes
Jan 31, 2020
|
No Release Notes |
|
I was unable to backport this PR to "7-1-x" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
@codebytere has manually backported this PR to "8-x-y", please check out #22011 |
deepak1556
reviewed
Feb 3, 2020
| print_settings.SetStringKey(printing::kSettingDeviceName, printer_name); | ||
|
|
||
| auto* print_view_manager = | ||
| printing::PrintViewManagerBasic::FromWebContents(web_contents()); |
There was a problem hiding this comment.
Continuing discussion about #21986 (comment) , the crash is caused by this line.
This function is registered as a weak callback to the task runner below, so that its not invoked when the api::WebContents is not available. Based on the crash it seems content::WebContents is not available in the callback, @zcbenz is it possible for api::WebContents to be alive while the content::WebContents is not ?
codebytere
added a commit
that referenced
this pull request
Feb 3, 2020
jkleinsc
pushed a commit
that referenced
this pull request
Feb 4, 2020
codebytere
added a commit
that referenced
this pull request
Feb 11, 2020
codebytere
added a commit
that referenced
this pull request
Feb 11, 2020
codebytere
added a commit
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Related to #21946, but distinct enough a unit of work that i've chosen to make this its own PR. This removes a section of
printing.patchby choosing the system default if no printer is passed by the user. This is what happened previously at the chromium level, but as a result of not setting thekSettingDeviceNamekey; we can instead take control of this ourselves.cc @deepak1556 @ckerr
Checklist
npm testpassesRelease Notes
Notes: Use system default printer if none is provided.