Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't crash on invalid certs #21976

Merged
merged 2 commits into from Jan 31, 2020
Merged

fix: don't crash on invalid certs #21976

merged 2 commits into from Jan 31, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Fixes #21973.

Looks like this probably got messed up with a Chromium roll. The OnceCallback can't be passed to two places.

Checklist

Release Notes

Notes: Fixed a crash that could occur when visiting HTTPS sites with invalid certificates.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2020
@nornagon nornagon mentioned this pull request Jan 30, 2020
Merged
6 tasks
@nornagon nornagon merged commit 45f30ea into master Jan 31, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2020

Release Notes Persisted

Fixed a crash that could occur when visiting HTTPS sites with invalid certificates.

@nornagon nornagon deleted the nornagon-patch-2 branch January 31, 2020 17:25
@nornagon nornagon mentioned this pull request Feb 10, 2020
Closed
3 tasks
nornagon added a commit that referenced this pull request Feb 10, 2020
@nornagon
fix: don't crash on invalid certs (#21976)
54eed81
@nornagon nornagon mentioned this pull request Feb 10, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

@nornagon has manually backported this PR to "8-x-y", please check out #22124

@trop trop bot added the in-flight/8-x-y label Feb 10, 2020
@nornagon
Copy link
Member Author

/trop run backport-to 9-x-y

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

The backport process for this PR has been manually initiated -
sending your commits to "9-x-y"!

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2020
@trop trop bot removed the in-flight/8-x-y label Feb 11, 2020
codebytere pushed a commit that referenced this pull request Feb 11, 2020
@nornagon
fix: don't crash on invalid certs (#22124)
637cf8a 
* test: add test for app.on('certificate-error') event (#21978)

* types

* fix: don't crash on invalid certs (#21976)
@trop trop bot added the merged/8-x-y label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browse to https page with invalid certificate causes crash
3 participants
@nornagon @zcbenz @deepak1556