fix: bind spellchecker receivers correctly in the renderer #21997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
bind-spellcheck-receiver
branch
from
e7ae355
to
313f6b4
Compare
MarshallOfSound
force-pushed
the
bind-spellcheck-receiver
branch
from
313f6b4
to
06ef673
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "8-x-y", please check out #22015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the chromium upgrade that included this change https://chromium-review.googlesource.com/c/chromium/src/+/1907273 we failed to correctly bind the new mojo-recievers for the spellchecker.
This PR does that 馃憤
Notes: The
dictionarySuggestionsproperty is now correctly populated when the built-in spellchecker is enabled