Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bind spellchecker receivers correctly in the renderer #22015

Merged
merged 1 commit into from Feb 3, 2020
Merged

fix: bind spellchecker receivers correctly in the renderer #22015

merged 1 commit into from Feb 3, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 3, 2020

Backport of #21997

See that PR for details.

Notes: The dictionarySuggestions property is now correctly populated when the built-in spellchecker is enabled

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2020
@trop trop bot requested a review from MarshallOfSound February 3, 2020 17:49
@trop trop bot mentioned this pull request Feb 3, 2020
Merged
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2020
@MarshallOfSound MarshallOfSound merged commit 9f2371f into 8-x-y Feb 3, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 3, 2020

Release Notes Persisted

The dictionarySuggestions property is now correctly populated when the built-in spellchecker is enabled

@MarshallOfSound MarshallOfSound deleted the trop/8-x-y-bp-fix-bind-spellchecker-receivers-correctly-in-the-renderer-1580752191219 branch February 3, 2020 19:48
@abarsov
Copy link

abarsov commented Feb 13, 2020 •
edited

@MarshallOfSound
I don't see the fix in 8.0.0 release notes. Wasn't it included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abarsov @MarshallOfSound