fix: generate symbols for the correct crashpad handler binary #23537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
May 12, 2020
|
@jkleinsc since this affects code only run on the release builds, would you mind triggering a release CI run? thanks 🙇 |
|
@nornagon macos release builds running here: https://app.circleci.com/pipelines/github/electron/electron/24347/workflows/ab1a0891-b1f8-4163-a0f3-0c85e389e73c |
|
Release builds are green so we're good to go. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "9-x-y", please check out #23573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The path of the crashpad handler changed in #23461 but wasn't updated for the correct symbols. This fixes that.
Checklist
Release Notes
Notes: Fixed missing debug symbols for crashpad handler on macOS.