Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate symbols for the correct crashpad handler binary #23573

Merged
merged 1 commit into from May 14, 2020
Merged

fix: generate symbols for the correct crashpad handler binary #23573

merged 1 commit into from May 14, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 13, 2020

Backport of #23537

See that PR for details.

Notes: Fixed missing debug symbols for crashpad handler on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 13, 2020
@trop trop bot requested a review from nornagon May 13, 2020 20:55
@trop trop bot mentioned this pull request May 13, 2020
Merged
3 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels May 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 13, 2020
@jkleinsc jkleinsc merged commit 3a51ee5 into 9-x-y May 14, 2020
@release-clerk
Copy link

release-clerk bot commented May 14, 2020

Release Notes Persisted

Fixed missing debug symbols for crashpad handler on macOS.

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-fix-generate-symbols-for-the-correct-crashpad-handler-binary-1589403303277 branch May 14, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @nornagon