fix: do not use CONTEXT_MENU flag for tray menu #23843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-tray-accessebility
branch
from
1285731
to
c8b991c
Compare
codebytere
approved these changes
May 29, 2020
ckerr
approved these changes
Jun 1, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "7-3-x" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
This was referenced Jun 1, 2020
|
I have automatically backported this PR to "10-x-y", please check out #23879 |
|
I have automatically backported this PR to "9-x-y", please check out #23880 |
4 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Jun 11, 2020
This reverts commit b809d10.
MarshallOfSound
added a commit
that referenced
this pull request
Jun 11, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
…)" (electron#24076) This reverts commit b809d10.
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
…)" (electron#24076) This reverts commit b809d10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #11587.
Tray menu does not popup on a window, so it should not use
CONTEXT_MENUflag otherwise some things would not work. The workaround used in #15302 stopped working after some Chromium upgrades.This PR makes our tray menu code aligned with Chromium
status_icon_win.cc.Release Notes
Notes: Fix tray menu on Windows not keyboard navigable.