Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the --disable-color-correct-rendering switch work again #23899

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 2, 2020

Backport of #23787

See that PR for details.

Notes: Fix disabling color correct rendering with --disable-color-correct-rendering

This regressed once again in Electron 8 due to Chromium changes.

Test Plan:

- Confirm that test case from #15898 (comment) now works

Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
@trop trop bot requested a review from a team as a code owner June 2, 2020 07:31
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Jun 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020
@jkleinsc jkleinsc merged commit c29382b into 10-x-y Jun 2, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 2, 2020

Release Notes Persisted

Fix disabling color correct rendering with --disable-color-correct-rendering

@jkleinsc jkleinsc deleted the trop/10-x-y-bp-fix-make-the-disable-color-correct-rendering-switch-work-again-1591083107014 branch June 2, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants