fix: do not register the node ESM loader in renderer processes #24301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add test for this change ? |
|
@deepak1556 and @MarshallOfSound i think yes - we added the sandbox change to ARM to account for this here, so we should be able to remove it now. If it fails, we know this didn't have the intended effect. |
codebytere
approved these changes
Jun 25, 2020
|
Failing vanilla node tests are related. |
|
oh boy missed those - i think we'll need to ensure it's enabled in run as node mode @MarshallOfSound |
|
@MarshallOfSound can you rebase this against the accepted upstream solution: nodejs/node#34060 |
codebytere
changed the title
codebytere
changed the title
5 tasks
|
No Release Notes |
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one ESM loader can be registered per isolate, in renderer processes this should be blink. This patches node so that it won't register its handler (overriding blinks) in non-browser processes.
Notes: no-notes