Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add focus and blur events for WebContents #25873

Merged
merged 1 commit into from Feb 1, 2022
Merged

feat: add focus and blur events for WebContents #25873

merged 1 commit into from Feb 1, 2022

Conversation

samuelmaddock
Copy link
Member

@samuelmaddock samuelmaddock commented Oct 10, 2020 •
edited

Description of Change

Adds 'focus' and 'blur' events to WebContents.

resolves #22201

cc @electron/wg-api

Checklist

Release Notes

Notes: Added 'focus' and 'blur' events to WebContents

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 10, 2020
samuelmaddock added a commit to samuelmaddock/electron-browser-shell that referenced this pull request Oct 10, 2020
@samuelmaddock
refactor: create PopupView class
30c337a 
Depends on changes in electron/electron#25873 and
electron/electron#25874
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2020
@samuelmaddock
Copy link
Member Author

@electron/wg-releases requesting to add 11-x-y backport label 🙇

@samuelmaddock samuelmaddock mentioned this pull request Oct 19, 2020
Open
nornagon
nornagon requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a test :)

@jkleinsc
Copy link
Contributor

The API WG approved this at our Oct 19 2020 meeting.

@samuelmaddock
Copy link
Member Author

@nornagon Tests added

@nornagon
Copy link
Member

Just to clarify, does this event also trigger when the browserwindow is focused (e.g. through alt+tab)? or only when focus stays in the browser window and switches between webcontentses?

@samuelmaddock
Copy link
Member Author

Just to clarify, does this event also trigger when the browserwindow is focused (e.g. through alt+tab)? or only when focus stays in the browser window and switches between webcontentses?

It does trigger when focusing the BrowserWindow. I've added a test to confirm: 89ad21d

@nornagon
Copy link
Member

@samuelmaddock it looks like the new test is failing on macOS.

@jkleinsc
Copy link
Contributor

The releases WG approved this PR for backport to 11-x-y at the Oct 28, 2020 meeting

@jkleinsc
Copy link
Contributor

jkleinsc commented Nov 2, 2020

@samuelmaddock any updates on this? Looks like we are close to being able to merge this if the test failures can be resolved.

@samuelmaddock
Copy link
Member Author

@samuelmaddock any updates on this? Looks like we are close to being able to merge this if the test failures can be resolved.

No updates, I'll see if I can get around to this by the end of the week.

@zcbenz zcbenz added the wip ⚒ label Jan 11, 2021
@lockieluke
Copy link

please get this merged asap

@jolindroth
Copy link

jolindroth commented Dec 28, 2021 •
edited

Any updates?

@samuelmaddock @jkleinsc @nornagon

@jolindroth jolindroth mentioned this pull request Dec 28, 2021
Closed
@nornagon nornagon added the semver/minor backwards-compatible functionality label Jan 28, 2022
@samuelmaddock samuelmaddock requested review from a team as code owners January 28, 2022 18:47
@samuelmaddock
feat: add focus and blur events for WebContents
d3a80e6 
test: add focus and blur WebContents event tests

test: confirm that webcontents focus event is fired on browserwindow focus

fix: mac focus event test timeout
@zcbenz zcbenz removed the wip ⚒ label Feb 1, 2022
@zcbenz zcbenz merged commit aeee9cf into electron:main Feb 1, 2022
@release-clerk
Copy link

release-clerk bot commented Feb 1, 2022

Release Notes Persisted

Added 'focus' and 'blur' events to WebContents

@zcbenz zcbenz mentioned this pull request Feb 2, 2022
Merged
@samuelmaddock samuelmaddock deleted the feat/webcontents-focus-events branch February 2, 2022 18:21
@commit-lint commit-lint bot mentioned this pull request Apr 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ api-review/requested 🗳 backport/approved ✅ no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'focus' & 'blur' events to BrowserView/WebContents
7 participants
@samuelmaddock @jkleinsc @nornagon @lockieluke @jolindroth @zcbenz @miniak