Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default offset when no BrowserView drag regions #27147

Merged
merged 1 commit into from Jan 4, 2021
Merged

fix: default offset when no BrowserView drag regions #27147

merged 1 commit into from Jan 4, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #27112.

Fixes an issue where non-draggable regions on BrowserViews would have an incorrectly assumed (x,y) origin of (0,0) which is an assumption that can be made for BrowserWindows but not for BrowserViews. In the latter case, we should calculate and pass the origin point of the BrowserView and pass it instead.

Checklist

Release Notes

Notes: Fixes an issue where non-draggable regions on BrowserViews could have incorrectly calculated bounds.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 29, 2020
@codebytere codebytere changed the title fix: default offset when no drag regions fix: default offset when no BrowserView drag regions Dec 29, 2020
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jan 4, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 4, 2021
@codebytere
Copy link
Member Author

Failure:

session.serviceWorkers getFromVersionID() should report the correct script url and scope

is not germane, merging.

@codebytere codebytere merged commit 6307b52 into master Jan 4, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2021

Release Notes Persisted

Fixes an issue where non-draggable regions on BrowserViews could have incorrectly calculated bounds.

@codebytere codebytere deleted the draggable-fix-offset branch January 4, 2021 22:01
This was referenced Jan 4, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I have automatically backported this PR to "11-x-y", please check out #27183

@trop trop bot removed the target/11-x-y label Jan 4, 2021
@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I have automatically backported this PR to "12-x-y", please check out #27184

@trop
Copy link
Contributor

trop bot commented Jan 4, 2021

I have automatically backported this PR to "10-x-y", please check out #27185

@PalmerAL PalmerAL mentioned this pull request Jan 4, 2021
Closed
@trop trop bot added the merged/11-x-y label Jan 5, 2021
@kevinlinv kevinlinv mentioned this pull request Jan 6, 2021
Closed
3 tasks
@codebytere codebytere mentioned this pull request Jan 14, 2021
Closed
3 tasks
@taras-slapdash taras-slapdash mentioned this pull request Jan 21, 2021
Closed
@codebytere codebytere mentioned this pull request May 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is the BrowserView being dragged?
2 participants
@codebytere @MarshallOfSound