fix: console windows from ELECTRON_RUN_AS_NODE instances #31973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
5 tasks
trop
bot
added
16-x-y
backport
deepak1556
approved these changes
Nov 23, 2021
|
Failing tests are unrelated, merging. |
deepak1556
deleted the
trop/16-x-y-bp-fix-console-windows-from-electron_run_as_node-instances-1637688863097
branch
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
Nov 25, 2021
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | patch | [`16.0.1` -> `16.0.2`](https://renovatebot.com/diffs/npm/electron/16.0.1/16.0.2) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v16.0.2`](https://github.com/electron/electron/releases/v16.0.2) [Compare Source](electron/electron@v16.0.1...v16.0.2) ### Release Notes for v16.0.2 #### Fixes - Fixed a potential issue when setting backgroundColor on `BrowserView`s. [#​31947](electron/electron#31947) <span style="font-size:small;">(Also in [14](electron/electron#31945), [15](electron/electron#31946), [17](https://github.com/electron/electron/pull/31948))</span> - Fixed console windows from ELECTRON_RUN_AS_NODE instances. [#​31973](electron/electron#31973) <span style="font-size:small;">(Also in [17](https://github.com/electron/electron/pull/31972))</span> #### Other Changes - Updated Chromium to 96.0.4664.55. [#​31909](electron/electron#31909) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/69 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31963
See that PR for details.
Notes: fix console windows from ELECTRON_RUN_AS_NODE instances