Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console windows from ELECTRON_RUN_AS_NODE instances #31963

Merged
merged 1 commit into from Nov 23, 2021
Merged

fix: console windows from ELECTRON_RUN_AS_NODE instances #31963

merged 1 commit into from Nov 23, 2021

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Nov 23, 2021 •
edited

Description of Change

When adopting 16.8.0 our global console window patch was replaced to adopt nodejs/node#39712 but it was not adopted for ELECTRON_RUN_AS_NODE instances leading to the creation of console windows when spawning console applications from a forked process.

Refs microsoft/vscode#137481

Gist example: https://gist.github.com/deepak1556/eefed2d47fada30c15ab9077d1532d0b

Checklist

Release Notes

Notes: fix console windows from ELECTRON_RUN_AS_NODE instances

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2021
@deepak1556 deepak1556 added target/16-x-y semver/patch backwards-compatible bug fixes labels Nov 23, 2021
@deepak1556 deepak1556 merged commit 9ab102e into main Nov 23, 2021
@deepak1556 deepak1556 deleted the robo/fix_console_window branch November 23, 2021 17:34
@release-clerk
Copy link

release-clerk bot commented Nov 23, 2021

Release Notes Persisted

fix console windows from ELECTRON_RUN_AS_NODE instances

This was referenced Nov 23, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 23, 2021

I have automatically backported this PR to "17-x-y", please check out #31972

@trop
Copy link
Contributor

trop bot commented Nov 23, 2021

I have automatically backported this PR to "16-x-y", please check out #31973

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@deepak1556 @t57ser
fix: console windows from ELECTRON_RUN_AS_NODE instances (electron#31963
c5c5c84 
)
@commit-lint commit-lint bot mentioned this pull request Feb 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere