New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make ElectronBrowser mojo interface frame associated. #32815
Merged
jkleinsc
merged 1 commit into
17-x-y
from
trop/17-x-y-bp-fix-make-electronbrowser-mojo-interface-frame-associated--1644338023254
Feb 9, 2022
Merged
fix: Make ElectronBrowser mojo interface frame associated. #32815
jkleinsc
merged 1 commit into
17-x-y
from
trop/17-x-y-bp-fix-make-electronbrowser-mojo-interface-frame-associated--1644338023254
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
trop
bot
added
17-x-y
backport
This is a backport PR
semver/patch
backwards-compatible bug fixes
labels
Feb 8, 2022
jkleinsc
approved these changes
Feb 9, 2022
Merging as CI failure unrelated to PR change. |
jkleinsc
deleted the
trop/17-x-y-bp-fix-make-electronbrowser-mojo-interface-frame-associated--1644338023254
branch
February 9, 2022 15:57
Release Notes Persisted
|
MarshallOfSound
pushed a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: Marek Haranczyk <marek@openfin.co>
MarshallOfSound
added a commit
that referenced
this pull request
May 4, 2022
… render frames (#33367) * Make ElectronBrowser mojo interface frame associated. (#32815) Co-authored-by: Marek Haranczyk <marek@openfin.co> * fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) (#33350) * fix: ensure ElectronBrowser mojo service is only bound to authorized render frames Notes: no-notes * refactor: extract electron API IPC to its own mojo interface * fix: just check main frame not primary main frame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co>
MarshallOfSound
added a commit
that referenced
this pull request
May 11, 2022
… render frames (#33367) * Make ElectronBrowser mojo interface frame associated. (#32815) Co-authored-by: Marek Haranczyk <marek@openfin.co> * fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) (#33350) * fix: ensure ElectronBrowser mojo service is only bound to authorized render frames Notes: no-notes * refactor: extract electron API IPC to its own mojo interface * fix: just check main frame not primary main frame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co>
MarshallOfSound
added a commit
that referenced
this pull request
May 12, 2022
… render frames (#34191) fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33367) * Make ElectronBrowser mojo interface frame associated. (#32815) Co-authored-by: Marek Haranczyk <marek@openfin.co> * fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) (#33350) * fix: ensure ElectronBrowser mojo service is only bound to authorized render frames Notes: no-notes * refactor: extract electron API IPC to its own mojo interface * fix: just check main frame not primary main frame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #32734
See that PR for details.
Notes: Fixed possible race conditions between frame state and electron ipc.