Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: only create webContents after 'will-attach-webview' #32941

Merged
merged 1 commit into from Jul 21, 2022
Merged

refactor: only create webContents after 'will-attach-webview' #32941

merged 1 commit into from Jul 21, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 17, 2022 •
edited

Description of Change

Merge createGuest and attachGuest handlers. Remove WebContentsPreferences::Merge.
Re-land #30311. I cannot reproduce #31689 with this change.

Checklist

Release Notes

Notes: WebContents for <webview> are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

@miniak miniak added the wip ⚒ label Feb 17, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 24, 2022
@miniak miniak marked this pull request as ready for review May 29, 2022 16:37
@miniak miniak requested a review from a team as a code owner May 29, 2022 16:37
@miniak miniak removed the wip ⚒ label May 29, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 29, 2022
@miniak
Copy link
Contributor Author

miniak commented May 29, 2022

@Kilian, @ckerr please review

@miniak miniak self-assigned this May 30, 2022
@miniak miniak added semver/patch backwards-compatible bug fixes target/20-x-y labels May 30, 2022
@codebytere codebytere merged commit d4e9748 into main Jul 21, 2022
@codebytere codebytere deleted the miniak/refactor-webview branch July 21, 2022 09:29
@release-clerk
Copy link

release-clerk bot commented Jul 21, 2022

Release Notes Persisted

WebContents for &lt;webview&gt; are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

@trop trop bot mentioned this pull request Jul 21, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jul 21, 2022

I have automatically backported this PR to "20-x-y", please check out #35016

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 21, 2022
@commit-lint commit-lint bot mentioned this pull request Sep 26, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@miniak @schetle
refactor: only create webContents after 'will-attach-webview' (electr…
94a86fe 
…on#32941)
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
refactor: only create webContents after 'will-attach-webview' (electr…
7c8aa5f 
…on#32941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @codebytere