fix: crash when showing item in folder on DevTools #33024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
zcbenz
reviewed
Feb 23, 2022
zcbenz
approved these changes
Feb 23, 2022
codebytere
force-pushed
the
fix-devtools-showiteminddolder
branch
from
0344393
to
5adf590
Compare
codebytere
force-pushed
the
fix-devtools-showiteminddolder
branch
from
5adf590
to
202569d
Compare
jkleinsc
approved these changes
Mar 8, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "16-x-y" cleanly; |
This was referenced Mar 8, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33196 |
|
I have automatically backported this PR to "18-x-y", please check out #33197 |
|
@codebytere has manually backported this PR to "16-x-y", please check out #33313 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33023.
Fixes an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash.
We were incorrectly passing an empty callback instead of a callback which calls
ShowItemInFolder. Chromium's call also opens the directory containing the file in their call toplatform_util::OpenItem, so we correct that on our end (since we don't pass an option to differentiate) by passing the file's parent directory toOpenPathChecklist
npm testpassesRelease Notes
Notes: Fixed an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash.