fix: max window size defaults to 0

[codebytere]

Description of Change

Closes #32995.

Fixes an issue where setting window maxHeight or maxWidth made it so the width and height could no longer be resized.

#32628 fixed an issue with maxWidth not being respected at all, but also changed defaults such that max_width and max_height conformed to size_constraints.GetMaximumSize(). By default, size_constraints.GetMaximumSize() returns (0, 0) unless it's been previously set, so this accidentally made it such that the maxHeight couldn't be changed if the maxWidth was set, and vice versa. This fixes that issue.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where setting window maxHeight or maxWidth made it so the width and height could no longer be resized.

[zcbenz]

Instead of setting maximum size to (INT_MAX, INT_MAX), the code should only call size_constraints.set_maximum_size when there is a maximum size set.

By default the window has a default maximum size that prevents it from being resized larger than screen, assigning a maximum size would override this behavior, see also:

electron/shell/browser/native_window_views.cc

Lines 211 to 217 in bcf060f

	if (enable_larger_than_screen())
	// We need to set a default maximum window size here otherwise Windows
	// will not allow us to resize the window larger than scree.
	// Setting directly to INT_MAX somehow doesn't work, so we just divide
	// by 10, which should still be large enough.
	SetContentSizeConstraints(extensions::SizeConstraints(
	gfx::Size(), gfx::Size(INT_MAX / 10, INT_MAX / 10)));

[codebytere]

Failure not relevant - merging.

[release-clerk]

Release Notes Persisted

Fixed an issue where setting window maxHeight or maxWidth made it so the width and height could no longer be resized.

[trop]

I have automatically backported this PR to "17-x-y", please check out #33118

[trop]

I have automatically backported this PR to "18-x-y", please check out #33119