Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max window size defaults to 0 #33119

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 1, 2022

Backport of #33025

See that PR for details.

Notes: Fixed an issue where setting window maxHeight or maxWidth made it so the width and height could no longer be resized.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 1, 2022
@trop trop bot requested a review from codebytere March 1, 2022 22:20
@trop trop bot mentioned this pull request Mar 1, 2022
3 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 1, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 1, 2022
@codebytere codebytere force-pushed the trop/18-x-y-bp-fix-max-window-size-defaults-to-0-1646173224071 branch from 581cc9e to ff5f752 Compare March 3, 2022 22:59
@jkleinsc jkleinsc merged commit 262cc48 into 18-x-y Mar 8, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-fix-max-window-size-defaults-to-0-1646173224071 branch March 8, 2022 19:20
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2022

Release Notes Persisted

Fixed an issue where setting window maxHeight or maxWidth made it so the width and height could no longer be resized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants