fix: report more detailed errors in shell.openExternal() on Windows #33620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/shell-open-external-error
branch
from
1cbbb6c
to
dfbff9d
Compare
zcbenz
approved these changes
Apr 6, 2022
codebytere
approved these changes
Apr 7, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "15-x-y", please check out #33656 |
|
I have automatically backported this PR to "16-x-y", please check out #33657 |
|
I have automatically backported this PR to "17-x-y", please check out #33658 |
|
I have automatically backported this PR to "18-x-y", please check out #33659 |
|
I have automatically backported this PR to "19-x-y", please check out #33660 |
|
/trop run backport-to 18-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "18-x-y", please check out #33705 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Report more detailed errors in
shell.openExternal()on Windows.Before:
After:
Checklist
npm testpassesRelease Notes
Notes:
shell.openExternal()now reports more detailed errors on Windows.