Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow null when subscribing notification #33771

Merged
merged 2 commits into from Apr 18, 2022
Merged

feat: allow null when subscribing notification #33771

merged 2 commits into from Apr 18, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 13, 2022

Backport of #33641

See that PR for details.

Notes: Enabled systemPreferences.subscribe{Local|Workspace}Notification to take a null value for the event parameter.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
@trop trop bot requested a review from codebytere April 13, 2022 20:03
@trop trop bot mentioned this pull request Apr 13, 2022
Merged
5 tasks
@trop trop bot added 18-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Apr 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
@jkleinsc
Copy link
Contributor

Merging as Windows CI is green but showing as in progress on the PR.

@jkleinsc jkleinsc merged commit 02562e9 into 18-x-y Apr 18, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-feat-allow-null-when-subscribing-notification-1649880184667 branch April 18, 2022 14:11
@release-clerk
Copy link

release-clerk bot commented Apr 18, 2022

Release Notes Persisted

Enabled systemPreferences.subscribe{Local|Workspace}Notification to take a null value for the event parameter.

@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
18-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere