Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: building with printing disabled #33838

Merged
merged 1 commit into from Apr 20, 2022
Merged

fix: building with printing disabled #33838

merged 1 commit into from Apr 20, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 19, 2022 •
edited

Description of Change

Related to #33602 and #33664

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@miniak miniak added backport-check-skip Skip trop's backport validity checking semver/none labels Apr 19, 2022
@nornagon nornagon merged commit a8a5c44 into 17-x-y Apr 20, 2022
@nornagon nornagon deleted the miniak/fix-no-printing-17-x-y branch April 20, 2022 20:50
@release-clerk
Copy link

release-clerk bot commented Apr 20, 2022

No Release Notes

@miniak
Copy link
Contributor Author

miniak commented May 9, 2022

/trop run backport-to 16-x-y

@trop
Copy link
Contributor

trop bot commented May 9, 2022

The backport process for this PR has been manually initiated - sending your PR to 16-x-y!

@trop
Copy link
Contributor

trop bot commented May 9, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@miniak miniak mentioned this pull request May 9, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2022

@miniak has manually backported this PR to "16-x-y", please check out #34153

@trop trop bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@deermichel deermichel deermichel approved these changes

@ppontes ppontes ppontes approved these changes

Assignees
No one assigned
Labels
17-x-y backport-check-skip Skip trop's backport validity checking semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @deepak1556 @deermichel @ppontes @nornagon