Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building with printing disabled #34153

Merged
merged 1 commit into from May 10, 2022
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 9, 2022

Backport #33838

In file included from ../../electron/shell/browser/electron_api_ipc_handler_impl.cc:5:
../../electron/shell/browser/electron_api_ipc_handler_impl.h:83:9: error: no template named 'AssociatedReceiver' in namespace 'mojo'; did you mean 'AssociatedRemote'?
  mojo::AssociatedReceiver<mojom::ElectronApiIPC> receiver_{this};
  ~~~~~~^~~~~~~~~~~~~~~~~~
        AssociatedRemote
../../mojo/public/cpp/bindings/associated_remote.h:39:7: note: 'AssociatedRemote' declared here
class AssociatedRemote {
In file included from ../../electron/shell/browser/electron_web_contents_utility_handler_impl.cc:5:
../../electron/shell/browser/electron_web_contents_utility_handler_impl.h:65:9: error: no template named 'AssociatedReceiver' in namespace 'mojo'; did you mean 'AssociatedRemote'?
  mojo::AssociatedReceiver<mojom::ElectronWebContentsUtility> receiver_{this};
  ~~~~~~^~~~~~~~~~~~~~~~~~
        AssociatedRemote
../../mojo/public/cpp/bindings/associated_remote.h:39:7: note: 'AssociatedRemote' declared here
class AssociatedRemote {

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 9, 2022
@trop trop bot mentioned this pull request May 9, 2022
2 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/none labels May 9, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 9, 2022
@miniak miniak added the backport-check-skip Skip trop's backport validity checking label May 9, 2022
@VerteDinde
Copy link
Member

WOA failure unrelated

@VerteDinde VerteDinde merged commit 6f46787 into 16-x-y May 10, 2022
@VerteDinde VerteDinde deleted the miniak/fix-no-printing-16-x-y branch May 10, 2022 18:13
@release-clerk
Copy link

release-clerk bot commented May 10, 2022

No Release Notes

@miniak
Copy link
Contributor Author

miniak commented May 18, 2022

/trop run backport-to 15-x-y

@trop
Copy link
Contributor

trop bot commented May 18, 2022

The backport process for this PR has been manually initiated - sending your PR to 15-x-y!

@trop
Copy link
Contributor

trop bot commented May 18, 2022

I have automatically backported this PR to "15-x-y", please check out #34273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants